[18.0][ADD] pre-commit #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cav-adhoc
force-pushed
the
18.0-partner-pre-commit
branch
from
c1768e6 to
dd5ee14
Compare
cav-adhoc
force-pushed
the
18.0-partner-pre-commit
branch
from
dd5ee14 to
2abc26a
Compare
vib-adhoc
requested changes
Feb 5, 2025
There was a problem hiding this comment.
@cav-adhoc Hola Cami, te dejé un comentario para que ajustes. El resto está perfecto!
partner_state/models/res_partner.py
Outdated
Comment on lines
75
to
76
| 'required field %s', ( | ||
| rec.display_name, partner_field))) |
There was a problem hiding this comment.
Cami, acá creo que los parámetros tienen que ir separados por coma. Si no va a querer reemplazar en el primer %s toda la tupla.
Quedaría algo así:
raise UserError(_(
'Partner "%s" can not request approval, '
'required field %s' % (
'required field %s', rec.display_name, partner_field))
2abc26a to
9ccdff3
Compare
|
@roboadhoc r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
closes #119 Signed-off-by: Virginia Bonservizi <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
roboadhoc
pushed a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.