[FIX] account_internal_transfer: Compute partner_id for internal transfer #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
from
1322a1c to
59d47bd
Compare
|
Nothing to update (base, title, body). No update to pr head. |
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
5 times, most recently
from
950d5a7 to
dd78935
Compare
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
11 times, most recently
from
7c0181b to
8d21820
Compare
rov-adhoc
changed the title
…sfers This commit adds a computed method _compute_partner_id that ensures internal transfers are assigned the partner from journal_id.company_id.partner_id. This avoids missing partner values in internal transfers.
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
from
8d21820 to
9bfe69f
Compare
roboadhoc
pushed a commit
to ingadhoc/account-payment
that referenced
this pull request
Feb 3, 2025
This commit implements the necessary corrections to ensure that the deposit of third-party checks, through the wizard, behaves the same way as an internal transfer. This ensures consistency in the process and prevents validation discrepancies. closes #607 Related: ingadhoc/account-financial-tools#637 Signed-off-by: Katherine Zaoral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a computed method _compute_partner_id that ensures
internal transfers are assigned the partner from journal_id.company_id.partner_id.
This avoids missing partner values in internal transfers.