Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Javascript components & finished Toggle button #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RiyaTayal20
Copy link
Contributor

@RiyaTayal20 RiyaTayal20 commented Aug 3, 2020

Screen Shot 2020-08-03 at 5 39 00 PM

Commit 1:

  • The inline javascript code in detail.html has been moved to its own js file called tabs.js. This component can be used for other pages that require tabs.
  • Another file was created (tab-init.js) to specifically invoke the details page tab-list
  • Created favorite-button.js to help with making a toggle button for a favorite contact
  • Made additional changes to detail.scss and detail.html to provide support for the toggle button.
  • Also installed ejs dependencies which made changes to package-lock.json & package.json

Commit 2:

  • Removed unnecessary comments
  • Made default tab "Company" again
  • Fixed logic in favorite-button.js if statement
  • Fixed styling of favorite toggle button in detail.scss & detail.html

Closes #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create some Javascript Components
1 participant