-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Ruby versions in health score calculation #5
Conversation
57f0f2f
to
194797a
Compare
@@ -23,6 +28,10 @@ def versions_for(gem_name) | |||
attr_reader :spec_type | |||
attr_reader :gem_versions | |||
|
|||
def fetch_ruby_versions | |||
gem_versions[RUBY_NAME] = RubyVersions.available_versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no ruby
gem: https://rubygems.org/gems/ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 awesome! 🎉
Let's see this in action. Merge to master, and before we release it, let's check it out on Revisor's staging environment (install gem from master)
Makes Ruby versions count towards the health score. The implementation adds Ruby as a dependency, i.e. a gem, so it can work with the existing API.
Released Ruby versions are fetched from
https://cache.ruby-lang.org/pub/ruby/index.txt
, which is an automatically generated file (more info here).Ruby has been given the same priority as Rails, which is 10.