Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Ruby versions in health score calculation #5

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

lovro-bikic
Copy link
Member

@lovro-bikic lovro-bikic commented Oct 24, 2024

Makes Ruby versions count towards the health score. The implementation adds Ruby as a dependency, i.e. a gem, so it can work with the existing API.

Released Ruby versions are fetched from https://cache.ruby-lang.org/pub/ruby/index.txt, which is an automatically generated file (more info here).

Ruby has been given the same priority as Rails, which is 10.

@lovro-bikic lovro-bikic changed the base branch from master to feature/refactor-code October 24, 2024 21:57
@lovro-bikic lovro-bikic changed the base branch from feature/refactor-code to master October 25, 2024 08:20
@lovro-bikic lovro-bikic force-pushed the feature/ruby-versions-in-health-score branch from 57f0f2f to 194797a Compare October 25, 2024 08:25
@@ -23,6 +28,10 @@ def versions_for(gem_name)
attr_reader :spec_type
attr_reader :gem_versions

def fetch_ruby_versions
gem_versions[RUBY_NAME] = RubyVersions.available_versions
Copy link
Member Author

@lovro-bikic lovro-bikic Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ruby gem: https://rubygems.org/gems/ruby

image

Copy link
Member

@cilim cilim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 awesome! 🎉

Let's see this in action. Merge to master, and before we release it, let's check it out on Revisor's staging environment (install gem from master)

@lovro-bikic lovro-bikic merged commit 9d9bd95 into master Oct 25, 2024
5 checks passed
@lovro-bikic lovro-bikic deleted the feature/ruby-versions-in-health-score branch October 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants