Change default class component props type from object to Record #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, any> to allow giving a JS component props in a TS file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default class component props type from object to Record<string, any> to allow giving a JS component props in a TS file. Earlier the props type was
{}which worked fine I guess. Now in version 9 it was changed toobject, which started to cause problems described in issue #1675. Changing the prop type to Record<string, any> seemed to solve the problems. Probably worth while to check that it des not suppress too much type checking where it is wanted.Before submitting a PR please:
npm run buildand check that the build succeeds.PR Template
Objective
This PR fixes issue #1675
Closes Issue
It closes Issue #1675