Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3428: Implement view-only session sharing #585

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Implements view-only sessions via /view URL endings:

  • Button added to header to copy relevant URLs
  • Presets and inputs disabled in view-only mode
  • Upload button disabled in view-only mode
  • Progress bar cancel button disabled in view-only mode
  • Related a11y updates

Notes

  • Forces session URLs to always have hash (#) endings -- this is due to the router failing to recognize non-hashed /view URLs, will be revisited as part of FI-3599
  • Manual URL editing may require multiple tries to force a reroute, also will be revisited as part of FI-3599
  • Minor bug: When progress bar cancel button is disabled, Tooltip has no title to display
  • Minor bug: Border color on auth card should be updated when inputs are disabled in view-only mode
  • Download button remains enabled in view-only mode
  • Run buttons may require icon changes

Testing Guidance

  1. Open any session. Make sure that the test session URL ends in #{test session ID}.
  2. Click the Share Session button in the header bar. Click Copy Read-Only Session Link. A success toast should pop up.
  3. In a new tab, navigate to the copied URL. Doing this in the same tab may require multiple attempts.
  4. The new session tab URL should end in /view.
  5. Test that all the following are disabled: presets, inputs/run buttons, upload button
  6. In the original tab, run some tests, ideally some that take a while to complete. In the view-only tab, refresh and the progress bar should appear. Make sure that the current run cannot be canceled.
  7. Check that navigating to other tests, the report page, and the config messages page maintains view-only mode.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 83.01158% with 44 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (84977e0) to head (0671c6b).

Files with missing lines Patch % Lines
...lient/src/components/Header/ShareSessionButton.tsx 67.61% 34 Missing ⚠️
...c/components/SuiteOptionsPage/SuiteOptionsPage.tsx 0.00% 3 Missing ⚠️
client/src/components/Header/Header.tsx 75.00% 2 Missing ⚠️
client/src/components/TestSuite/TestSession.tsx 33.33% 2 Missing ⚠️
...s/TestSuite/TestSuiteDetails/TestSuiteMessages.tsx 50.00% 2 Missing ⚠️
client/src/components/Skeletons/HeaderSkeleton.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   84.29%   84.23%   -0.07%     
==========================================
  Files         275      276       +1     
  Lines       11668    11864     +196     
  Branches     1302     1339      +37     
==========================================
+ Hits         9836     9994     +158     
- Misses       1822     1860      +38     
  Partials       10       10              
Flag Coverage Δ
frontend 79.23% <83.01%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant