Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix CI #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lewiscowles1986
Copy link

@Lewiscowles1986 Lewiscowles1986 commented Jul 7, 2022

I Noticed this 2018 commit is broken, and that tests cannot be run against PHP 8.1. It also does not document which PHP Unit version the tests were for.

This does a few things:

  • Yoast polyfill so PHP 5.4 - 8.1 compatible PHPUnit should "just work"
  • use namespace for TestCase instead of older globally available classname
  • Basic gitignore for the vendor and lock file
  • update composer.json to indicate PHP 5.4+ (this is very old)
  • require_once instead of require (seems to avoid double-loading file)

I Can make a separate PR if required / desired to update the GitHub action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant