-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 288 and 279 #289
Merged
+533
−153
Merged
Fix 288 and 279 #289
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
201737e
Fix #279
damianooldoni d58f547
Add test about expected columns returned
damianooldoni 22eda44
Creates meaningful examples of using minDeltaTime
damianooldoni 3dbd53b
Update species in example comment
damianooldoni f2aabf5
Update a test after adding column n
damianooldoni 88f7641
Adjust threshold for removing not independent obs
damianooldoni 7be7555
Add line in news about solving #279
damianooldoni 553bf1c
Add new column to vignette
damianooldoni 2710a3c
Add examples about duplicate removel in examples
damianooldoni fc60b6f
Update chunks about duplicates based on new mica dataset
damianooldoni f37ef07
Use mica_dup instead of mica_duplicates
damianooldoni d8dc125
Explain why using 3rd obs as template for mica_dup
damianooldoni c2b320f
Use 3rd timestamp in test
damianooldoni 1ea3aea
Use mica_dup instead of mica_duplicates
damianooldoni ba7eb71
Fix #288
damianooldoni 0c01da0
Run devtools::document
damianooldoni 6e1fef4
Add check reserved words in station column
damianooldoni 9e101f8
Remove NAs before checking presence reserved words
damianooldoni d208521
Add tests of new features
damianooldoni 9f5d484
Update vignette describing new features
damianooldoni 2a1181e
Report new features of get_cam_op in NEWS.md
damianooldoni 3870869
Remove typo
damianooldoni ac380cd
Load dplyr in examples to use %>%
damianooldoni a593839
Add importFrom for rlang symbols !! and :=
damianooldoni bf09332
Run devtools::document()
damianooldoni 8eccfa2
Improve grammar
damianooldoni 5a81082
use `testthat::expect_named()` instead of `expect_identical(colnames(…
PietrH 55d1eba
add missing space in documentation
PietrH 68f591c
use `is.matrix()` for a slightly better failure message
PietrH 3af4488
Mention the specific argument needed to specify
PietrH e7d99ad
Reduce numerical tolerance, increase strictness
PietrH a31614d
use comparison expectations for better failure messages
PietrH 4dcdd65
increase test strictness by removing tolerance
PietrH c264eba
No need to announce testthat namespace in tests
PietrH 41afe9a
clarify default behaviour
PietrH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally use
purrr::chuck()
for this so I throw an error when I try to access an index that doesn't exist. I'm not really sure what the base behaviour is in this case. Ok to leave like this.