Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major improvements in UI, improve UX #12

Merged
merged 9 commits into from
Jan 6, 2021
Merged

major improvements in UI, improve UX #12

merged 9 commits into from
Jan 6, 2021

Conversation

tusharnankani
Copy link

@tusharnankani tusharnankani commented Jan 4, 2021

What is the change?

This PR includes:

  • Switched to a more readable font.
  • navbar changes
    • add transitions
    • remove background hover
    • improve color coordination
nav.mp4
  • footer changes
    • increase padding
    • improve hover effect
    • minor fix of mailto
foot.mp4
  • Card changes:
    • add box-shadow to the card
    • add transition when hovered on courses
    • change gif images layout to circular
    • improve the user experience
card.mp4

Related issue?

In reference to #4

Files edited?

  • views/partials/header.ejs
  • views/partials/footer.ejs
  • public/css/index.js

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes like this ([x]).

  • I've checked there aren't other open Pull Requests for the same update/change?
  • I've made corresponding changes to the documentation?
  • My submission doesn't break any existing feature.
  • I've tested this code locally before submission?

@Nishant2907

Nishant2907 and others added 8 commits December 18, 2020 01:59
* updated readme

* updated readme

* updated readme

* updated readme

* updated readme

* updated

* updated readme

* updated readme

* updated readme

* updated

* updated readme

* changed color

* updated

* updated

* updated

* updated readme

* updated readme

* updated

* updated

* updated
@tusharnankani
Copy link
Author

@Nishant2907 any updates?

Copy link
Member

@Nishant2907 Nishant2907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and look good to me.

@Nishant2907 Nishant2907 changed the base branch from master to develop January 6, 2021 18:13
@Nishant2907
Copy link
Member

@tusharnankani, there are some conflicts in the index.css file. Kindly resolve it.

@tusharnankani
Copy link
Author

@tusharnankani, there are some conflicts in the index.css file. Kindly resolve it.

Fixed.

Copy link
Member

@Nishant2907 Nishant2907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine.

@Nishant2907 Nishant2907 merged commit 3fe8ba1 into inaxia:develop Jan 6, 2021
@tusharnankani tusharnankani deleted the navbar-footer branch January 7, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants