Integrate bjbrewster rerender fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted util methods to allow mocking for tests - Include single lodash methods instead of all to reduce bundle size - Add initial component test
- Added snapshot test for future changes - Replaced useDeepCompareEffect with simpler version using JSON.stringify It should have been !isDeepEqual and not include callback in deps. - Added fixed width/height in test for snapshots. - selectedRef was used incorrectly. - iniChart no longer recreated each render. I will extract to utils next. - No longer re-inits every render due to props object changed.
- Removed re-render on resize. Not required when using relative viewbox coords. - Moved arcChart and pieChart generators into renderChart. Recreate when used. - Fix calling renderChart twice on first render
- Change setArcData to getArcData - Removed unrequired refs - Greatly optimised calculation - renderChart() will be split into create/update arc and needle and only called when props changed
div html elements already have width 100% as they are display: block by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various component rerender issues. See Martin36#81