Fix serialization of SLSA BuildMetadata.InvocationID #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per the docs, the correct serialization is "invocationId": https://slsa.dev/spec/v1.0/provenance#:~:text=%3A%20%7B%0A%20%20%20%20%20%20%20%20%20%20%20%20%22-,invocationId,-%22%3A%20old This aligns this (deprecated) version with the proto-based one in in-toto/attestation: https://github.com/in-toto/attestation/blob/main/go/predicates/provenance/v1/provenance.pb.go#L287C85-L287C97 Signed-off-by: Matthew Suozzo <[email protected]>
|
could you sign off the second commit? |
Signed-off-by: Matthew Suozzo <[email protected]>
Done. sorry about that! |
adityasaky
approved these changes
May 14, 2024
|
Thanks for the quick turnaround @adityasaky !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per the docs, the correct serialization is "invocationId": https://slsa.dev/spec/v1.0/provenance#:~:text=%3A%20%7B%0A%20%20%20%20%20%20%20%20%20%20%20%20%22-,invocationId,-%22%3A%20old
This aligns this (deprecated) version with the proto-based one in in-toto/attestation: https://github.com/in-toto/attestation/blob/main/go/predicates/provenance/v1/provenance.pb.go#L287C85-L287C97
Fixes issue:
Fixes #260
Description:
Please verify and check that the pull request fulfills the following
requirements: