use http.ErrUseLastResponse to prevent return error in NoRedirectPolicy

imroc · Aug 10, 2022 · 19d3d87 · 19d3d87
1 parent 0cb6666
commit 19d3d87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/client_test.go b/client_test.go
@@ -346,8 +346,7 @@ func TestKeepAlives(t *testing.T) {
 
 func TestRedirect(t *testing.T) {
 	_, err := tc().SetRedirectPolicy(NoRedirectPolicy()).R().Get("/unlimited-redirect")
-	tests.AssertNotNil(t, err)
-	tests.AssertContains(t, err.Error(), "redirect is disabled", true)
+	tests.AssertIsNil(t, err)
 
 	_, err = tc().SetRedirectPolicy(MaxRedirectPolicy(3)).R().Get("/unlimited-redirect")
 	tests.AssertNotNil(t, err)

diff --git a/redirect.go b/redirect.go
@@ -24,7 +24,7 @@ func MaxRedirectPolicy(noOfRedirect int) RedirectPolicy {
 // NoRedirectPolicy disable redirect behaviour
 func NoRedirectPolicy() RedirectPolicy {
 	return func(req *http.Request, via []*http.Request) error {
-		return errors.New("redirect is disabled")
+		return http.ErrUseLastResponse
 	}
 }
 
@@ -111,7 +111,8 @@ func getDomain(host string) string {
 // sensitive ones to the same origin, or subdomains thereof (https://go-review.googlesource.com/c/go/+/28930/)
 // Check discussion: https://github.com/golang/go/issues/4800
 // For example:
-// 	 client.SetRedirectPolicy(req.AlwaysCopyHeaderRedirectPolicy("Authorization"))
+//
+//	client.SetRedirectPolicy(req.AlwaysCopyHeaderRedirectPolicy("Authorization"))
 func AlwaysCopyHeaderRedirectPolicy(headers ...string) RedirectPolicy {
 	return func(req *http.Request, via []*http.Request) error {
 		for _, header := range headers {