Add missing function trim_all_columns(df) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @e-maud
I am researching interfaces of digitized newspapers in the Portuguese language as part of my postdoctoral research at the DH_Lab of the Universidade Nova de Lisboa.
This is an extension of previous research on the Hemeroteca Digital Brasileira (Digital Newspaper Library of Brazil) at the National Library of Brazil.
Your paper 'Historic Newspaper User Interfaces: A Review (2019)' has served as a methodological foundation for the analysis of the interfaces of digital newspaper libraries in Brazil and Portugal. I would like to express that it is an incredible work and an inspiration for my reflections, as well as the entire work of the impresso project.
While attempting to execute the notebook to analyze the TSV, I noticed that in the current version, the function
trim_all_columns(df)
is missing both in the.ipynb
file and in theinterface/radar_factory.py
file.It was present in an earlier version of the
.ipynb
file, which can be seen here: link to GitHubThe function is as follows:
I have included the function in the file
interface/radar_factory.py
, as in the.ipynb
file, it is being imported frominterface.radar_factory
.