Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timestamp for last edit in UG tutor form #51

Merged
merged 10 commits into from
Jan 22, 2025
Merged

feat: add timestamp for last edit in UG tutor form #51

merged 10 commits into from
Jan 22, 2025

Conversation

estifraca
Copy link
Contributor

We've added the message "Last edited by .... on ...." on the top of UG tutor form.
For that, lastUserEditBy and lastUserEditOn were added to InternalReview.

image

@estifraca estifraca requested a review from zaki-amin January 21, 2025 11:00
@zaki-amin
Copy link
Contributor

The shortcuts (tick boxes) for changing the next action from Inform Candidate and Final Check aren't updating the timestamps and email for the last user edit. Same with updating the outcomes and comments on the UG tutor dialog.

@procaconsul procaconsul changed the title Feat add timestamp for last edit in UG tutor form feat: add timestamp for last edit in UG tutor form Jan 21, 2025
procaconsul
procaconsul requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@procaconsul procaconsul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up from Zaki's comment, waiting on the fix :)

@procaconsul procaconsul merged commit 52fb79a into main Jan 22, 2025
16 checks passed
@procaconsul procaconsul deleted the feat-add-timestamp-for-last-edit branch January 22, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaki-amin zaki-amin zaki-amin left review comments

@procaconsul procaconsul procaconsul approved these changes

Assignees

@estifraca estifraca

@jasebaileyicl jasebaileyicl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estifraca @zaki-amin @procaconsul @jasebaileyicl