Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake portability improvements #686

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jschueller
Copy link

No description provided.

@jschueller jschueller marked this pull request as ready for review September 1, 2023 15:06
@jschueller
Copy link
Author

@mnwright it should build now, could you restart the CI ?

@jschueller
Copy link
Author

hello @mnwright could you look at this one please ?

@mnwright
Copy link
Member

mnwright commented Oct 7, 2024

Could you explain the changes a little bit? My cmake is a little rusty.

@jschueller
Copy link
Author

yes, of course:

  • We must check if the -Wall flag is supported by the compiler, eg unsupported on msvc
  • We build ranger as a library can be used from another c++ project
  • The minimum cmake version must be incremented to 3.5 to avoid warnings (3.5 is pretty old anyways)
  • We add an install rule (to be able to do "make install") so that ranger is easier to use in package managers
  • We add a getopt function for targets where its unsupported (msvc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants