Evm gas cost stage 3

[JacekGlen]

No description provided.

[JacekGlen]

Use TS imports rather than JS require:

Suggested change

	const { ArgumentParser } = require('argparse')
	const { Benchmark } = require('benchmark')
	const _ = require('lodash')
	const { Block } = require('@ethereumjs/block')
	const { Blockchain } = require('@ethereumjs/blockchain')
	const { Common, Hardfork, ConsensusType, ConsensusAlgorithm } = require('@ethereumjs/common')
	const { MemoryLevel } = require('memory-level')
	const { EEI } = require('@ethereumjs/vm')
	const { EVM } = require('@ethereumjs/evm')
	const { DefaultStateManager } = require('@ethereumjs/statemanager')
	const { Address, MAX_INTEGER_BIGINT, KECCAK256_RLP_ARRAY } = require('@ethereumjs/util')
	import { ArgumentParser } from 'argparse'
	import benchmark from 'benchmark'
	import _ from 'lodash'
	import { Block } from '@ethereumjs/block'
	import { Blockchain } from '@ethereumjs/blockchain'
	import { Common, Hardfork, ConsensusType, ConsensusAlgorithm } from '@ethereumjs/common'
	import { MemoryLevel } from 'memory-level'
	import { EEI } from '@ethereumjs/vm'
	import { EVM } from '@ethereumjs/evm'
	import { DefaultStateManager } from '@ethereumjs/statemanager'
	import { Address, MAX_INTEGER_BIGINT, KECCAK256_RLP_ARRAY } from '@ethereumjs/util'

[stan7123]

Done.
Although my IDE is showing some lines with red underline ;)

[JacekGlen]

Declaring type seems unusual, class is more standard

Suggested change

	type Stats = {
	class Stats {

[JacekGlen]

Use camelCase which is consistent with the rest of the code base:

Suggested change

	run_id?: number
	runId?: number

[JacekGlen]

That becomes

Suggested change

	const bench = new Benchmark({
	const bench = new benchmark({

if you use imports

[JacekGlen]

1 sample seems a bit low. Can we make it higher?

[stan7123]

Changed to default which is 5.

[JacekGlen]

That seems a bit convoluted, is there a reason for this?

If not, we can remove .on('complete') event and simply have something like this:

  bench.run()
  let result : Stats = {
      iterations_count: bench.count,
      total_time_ns: Math.round(bench.stats.mean * 1_000_000_000),
      std_dev_time_ns: Math.round(bench.stats.deviation * 1_000_000_000),
  }

  return result

[stan7123]

The reason is that I want to wait for the async code to be benchmarked. The only way with benchmark.js is to wait for complete event to be emitted and then resolve the whole runBenchmark function.