Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine that works with rails version of resque-web #27

Merged
merged 12 commits into from
Apr 3, 2014

Conversation

mcfiredrill
Copy link
Contributor

Resque 2 will not come with the sinatra web interface. There is a new rails based project, resque-web that will replace it. I implemented a way for resque plugins to extend this new rails based interface, and resque-history is the first plugin I've tried it with.

I'd like to merge this into the resque2.0 branch.

@ilyakatz
Copy link
Owner

ilyakatz commented Mar 3, 2014

@mcfiredrill thanks for the pull request. Did you branch from master? There seems to be a many commits that should not show up if compared to resque2 branch

Also, this line uses ruby 1.9 notation. Would you mind updating it to 1.8 notation to keep the gem backward compatible.

mcfiredrill@005df85#diff-9b045d18fffc94d745ca85bf67eeaf7fR13

this line seems to be using ruby 1.9 notation

resource :history, only: [:show,:destroy]

@mcfiredrill
Copy link
Contributor Author

Oops sorry, I guess I did branch from master.
That said, why is the resque2 branch behind so many commits? It could especially use the one about removing the dependency on resque helpers right?

Yeah, I don't mind changing to 1.8 hash notation, but are you aware that 1.8 has reached EOL ? https://www.ruby-lang.org/en/news/2013/06/30/we-retire-1-8-7/

@ilyakatz
Copy link
Owner

ilyakatz commented Mar 3, 2014

@mcfiredrill good point, I guess I've slacked off on making sure that resque2 is in synch with master. I will take care of it.

Also, i just checked master resque gemspec and looks like it's requiring 1.9.3 minimum, so it's fine to leave as is.

I guess I'll need to do some cleanup and bring resque2 branch to master. Will try to do it in the next couple of days. Have you used it successfully with resque2?

@mcfiredrill
Copy link
Contributor Author

I've been using this with resque-web in production on resque 1.25 for about a month, but I haven't actually tried with resque 2 yet. :) I'll try it out.

@mcfiredrill
Copy link
Contributor Author

Any update on this? I could give you a hand with it if you need. Is it just a matter of sorting out the resque 2 branch?

@ilyakatz ilyakatz merged commit 005df85 into ilyakatz:resque2.0 Apr 3, 2014
@ilyakatz
Copy link
Owner

ilyakatz commented Apr 3, 2014

@mcfiredrill thanks for the reminder. I've merged your changes but the branch is not passing yet. I've started playing around with fixing (#31) it but getting a bit stuck, so definitely wouldn't mind some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants