-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can do sbt +lihua/publishLocal #876
base: master
Are you sure you want to change the base?
Conversation
The cmd result
|
Following up: I am trying to cross compile core. After making necessary changes to build.sbt, i got
Looks like macros in scala2 and scala3 work pretty differently. |
Both strategies worth trying. crossVersionUser213for3 might be a good intermediate step before we fully migrate to Scala3. |
Good point. I have some basic understanding of Functor and Contravariant, I do need some more practice. Ok, I will focus on tagless in the next sprints. |
Summary
This is a tentative change to make lihua cross compile to scala 3(.2.2). The compile was successful. The goal isn't to merge this code or might not have to develop upon this PR, but rather to spark conversations and learnings.
Line of thought
I tried to make the change minimal for this cross compile. The outcome seems satisfying.
There is another branch i tried something a bit different. mostly around the class EntityId.
EntityId is a wrapped string, with the help of newtype lib. In scala3, this can be achieved using opaque type.
In a separate toy project, I am able to separate scala2 and scala3 code, each defines EntityId in the way talked above and it worked.
Let's talk about if all this makes sense