Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IHRDS 3171 tester user should be able to change override #873

Merged
merged 3 commits into from
Oct 11, 2023
Merged

IHRDS 3171 tester user should be able to change override #873

merged 3 commits into from
Oct 11, 2023

Conversation

lofoyet
Copy link
Contributor

@lofoyet lofoyet commented Oct 10, 2023

  • non test setting change should not care about last updated time
  • add test
  • update tests

kailuowang
kailuowang approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lofoyet lofoyet merged commit 3ac529d into master Oct 11, 2023
@lofoyet lofoyet deleted the IHRDS-3171 branch October 11, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lofoyet @kailuowang