IHRDS 3159 handle bad request body for /users/groups/query

[lofoyet]

Summary

• handle invalid request body for endpoint "users" / "groups" / "query"
• added test case (don't expect them to be in the right format)

Reference

I don't expect to write unit test like this, so I am open to any change.

[kailuowang]

Looks great to me. The only nitpick I have is that the test should probably be in the com.iheart.thomas.http4s.abtest package.

[lofoyet]

com.iheart.thomas.http4s.abtest

good point, done

[kailuowang]

hmm you might have to move the TestUtil into com.iheart.thomas package.

[lofoyet]

hmm you might have to move the TestUtil into com.iheart.thomas package.

I am not sure why it gave an error. locally the test looks ok.
i can try to move move the TestUtil into com.iheart.thomas package. to get some clarification, TestUtils is will still be in the tests/it/ package instead of the tests/test/ package right?

[lofoyet]

interesting, when i run that test alone it's ok, when i do sbt validate i got the same error

[kailuowang]

I don't know why it passes when you run it alone. But your new test is not in the right folder. It should be in the It folder since it's an integration tests. tests in tests/test folder won't be able to access TestUtils

[lofoyet]

Yes, you are right, i just realized so. my test depends on mongo, so just like you said, it fits more like an it test maybe not unit test.
I think moving the EndpointSuite to src/it/ is the right way to go. what's your thought?
@kailuowang

[kailuowang]

Correct. That's the idea

…

On Tue, Oct 10, 2023, 2:18 PM Tony ***@***.***> wrote: Yes, you are right, i just realized so. my test depends on mongo, so just like you said, it fits more like an it test maybe not unit test. I think moving the EndpointSuite to src/it/ is the right way to go. what's your thought? @kailuowang <https://github.com/kailuowang> — Reply to this email directly, view it on GitHub <#872 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAUKOI2BY3YB2QJPPDGHMDX6WGQDAVCNFSM6AAAAAA5WCQ2ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVHE4DKOJTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>