Implement XEP-0444: Message Reactions in Smack #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for XEP-0444 (Message Reactions) in Smack. Key changes include: - Added ReactionsManager to handle reactions, including adding, removing, and listening for reactions on messages. - Introduced ReactionsElement and Reaction classes to represent the <reactions> element and individual emoji reactions. - Added ReactionsFilter to detect messages containing reactions. - Implemented ReactionRestrictions to manage restrictions like max reactions per user and allowed emojis. - Integrated reaction restrictions with XMPP service discovery. - Added ReactionsListener for applications to handle incoming reactions. - Included unit tests to verify functionality. This enables emoji reactions in XMPP messages, with support for restrictions and service discovery. Related: XEP-0444 (https://xmpp.org/extensions/xep-0444.html)
Flowdalic
requested changes
Jan 30, 2025
| public static DataForm createReactionRestrictionsForm(int maxReactionsPerUser, List<String> allowedEmojis) { | ||
|
|
||
| DataForm.Builder builder = DataForm.builder(); | ||
| builder.setFormType(String.valueOf(DataForm.Type.result)); |
There was a problem hiding this comment.
That String.valueOf can probably be dropped.
| * @param listener The reactions listener to be added. | ||
| */ | ||
| public synchronized void addReactionsListener(ReactionsListener listener){ | ||
| listeners.add(listener); |
There was a problem hiding this comment.
We usually expose the return value of add()
| * @param listener The reactions listener to be removed. | ||
| */ | ||
| public synchronized void removeReactionsListener(ReactionsListener listener){ | ||
| listeners.remove(listener); |
There was a problem hiding this comment.
We usually expose the return value of remove()
| FormField.Builder<TextSingleFormField, TextSingleFormField.Builder> allowlistFieldBuilder = FormField.builder("allowlist"); | ||
| for (String emoji : allowedEmojis) { | ||
| Reaction reaction = new Reaction(emoji); | ||
| FormField.builder("value").setValue((CharSequence) reaction); |
There was a problem hiding this comment.
This cast to CharSequence probably does not what you want.
| while (true) { | ||
| XmlPullParser.Event tag = parser.next(); | ||
|
|
||
| if (tag == XmlPullParser.Event.END_ELEMENT && parser.getName().equals(ReactionsElement.ELEMENT)) { |
There was a problem hiding this comment.
Please follow the idiom in the other Providers where we break out of the lop if END_ELEMENT and depth are correct.
|
|
||
| ReactionsManager.addReactionsToMessage(message, emojis, messageId, null); | ||
|
|
||
| ReactionsElement reactionsElement = (ReactionsElement) message.getExtensionElement(ReactionsElement.ELEMENT, ReactionsElement.NAMESPACE); |
There was a problem hiding this comment.
Casts are bad, better use the type safe approach (may need adjustments)
Suggested change
| ReactionsElement reactionsElement = (ReactionsElement) message.getExtensionElement(ReactionsElement.ELEMENT, ReactionsElement.NAMESPACE); | |
| ReactionsElement reactionsElement = message.getExtensionElement(ReactionsElement.class); |
| reactionsManager.reactionsElementListener(message); | ||
|
|
||
| // Assertions: Ensure that the message contains the reactions element | ||
| assertNotNull(message.getExtensionElement(ReactionsElement.ELEMENT, ReactionsElement.NAMESPACE)); |
There was a problem hiding this comment.
Suggested change
| assertNotNull(message.getExtensionElement(ReactionsElement.ELEMENT, ReactionsElement.NAMESPACE)); | |
| assertNotNull(message.getExtensionElement(ReactionsElement.class)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for XEP-0444 (Message Reactions) in Smack. Key changes include:
This enables emoji reactions in XMPP messages, with support for restrictions and service discovery.
Related: XEP-0444 (https://xmpp.org/extensions/xep-0444.html)