[sinttest] Allow custom processing of test run result #588
Conversation
guusdk
force-pushed
the
sint_configurable-testresultprocessor
branch
2 times, most recently
from
ae11892 to
a34e1af
Compare
smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Outdated
Show resolved
Hide resolved
...ation-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
Show resolved
Hide resolved
|
Applied all review feedback. |
|
Squash please. |
This adds a new configuration option, `testRunResultProcessors`, that allows a user to customize the way the results of a test run is processed. By default, the pre-exising printing-to-stderr is used.
guusdk
force-pushed
the
sint_configurable-testresultprocessor
branch
from
d35904f to
5622bb0
Compare
|
Squashed. |
| @@ -473,6 +480,15 @@ public Builder setCompatibilityMode(String compatibilityModeString) { | |||
| return setCompatibilityMode(compatibilityMode); | |||
| } | |||
|
|
|||
| public Builder setTestRunResultProcessors(String testRunResultProcessorsString) { | |||
| if (testRunResultProcessorsString == null) { | |||
There was a problem hiding this comment.
Calling a public API like this with null should usually throw an exception. It is not defined that calling this method with null actually does and therefore it is most likely a sign of a programming error, e.g., the user wanting to set a result processor for somehow it ended up being null.
The same argument can be made for the empty string.
Therefore, use StringUtils.requireNonNullNorEmpty(testRunResultProcessorString) here.
There was a problem hiding this comment.
I'm happy to change this, but it's a pattern that's used throughout this implementation. Do you want me to change it everywhere?
There was a problem hiding this comment.
Uh, fair point. Thanks for pointing this out. There is probably more to it that I don't remember.
In any case, if this is going to get changed, it will be done outside of this PR for all methods.
This adds a new configuration option,
testRunResultProcessors, that allows a user to customize the way the results of a test run is processed.By default, the pre-exising printing-to-stderr is used.