Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saga Start of xml templates #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Saga Start of xml templates #1

wants to merge 8 commits into from

Conversation

Marie59
Copy link

@Marie59 Marie59 commented Nov 7, 2024

Just started the work

I have put in the excel document the different comments and questions and also in purple what need to be done.
I put here also the skeleton of an eventual workflow for the Illumina part for now https://usegalaxy.eu/u/marie.josse/w/unnamed-workflow

So from this workflow you can see that I will work on the orange parts.

  • Add an existing qiime2 tool in galaxy europe to import a collection and create a qza (done waiting for galaxy europe deployment
  • 2 tools for FIGARO
  • 2 tools for swarm (check out frogs https://github.com/geraldinepascal/FROGS-wrappers/blob/master/tools/frogs/clustering.xml)
  • Qiime2 dbOTU I tried to see from the other qiime2 tools but I could not fin a real example of how to use the dbotu pluggin I need to test it to see
  • Picrust2 plots here I am wondering if this R script needs to be wrapped or if an other visualisation tool of Galaxy could be used ? and if we do need this specific script we need to generalized it.
  • Finally, the different diversity calculations that will be done in a 2nd time

In this PR I will review directly the bits of code where I have question (regarding inputs, outputs and so on)
@lleroi Does this way of working fits you ? (I wanted to add some issues but I don't see the issue button in top pannel.... it's weird)

<yield/>
</requirements>
</xml>
<xml name="figaro_edam">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I'll need on to find the right edam ontologies for figaro (I tried to find on Bio tools but it's not obvious to me which are the ontologies if they are there)

<edam_operation>operation_TODO</edam_operation>
</edam_operations>
</xml>
<xml name="figaro_bibref">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO DO find some citation for each tools

<requirement type="package" version="0.8.9">r-grid</requirement>
<requirement type="package" version="0.8.9">r-rcolorbrewer</requirement>
<requirement type="package" version="0.8.9">r-ggpubr</requirement>
<requirement type="package" version="0.8.9">r-ggplot2</requirement>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO DO put the real version of packages (for now it's just a bad copy paste) for those with real versions I put the latest one available on anaconda.
Maybe better if I take the ones from the environment you created ?

tools/samba/illumina_suite/figaro.xml Outdated Show resolved Hide resolved

]]></command>
<inputs>
<param name="raw_data" type="data" format="" label="Raw data" help="TODO" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which format in expected here

tools/samba/illumina_suite/qiime2_dbotu_q2.xml Outdated Show resolved Hide resolved
<container type="docker">quay.io/qiime2/amplicon:2024.10</container>
</requirements>
<version_command>q2galaxy version dbotu_q2</version_command>
<command detect_errors="exit_code">q2galaxy run dbotu_q2 call_otus '$inputs'</command>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not sure at all I just wrote the command with how I felt it could be

<inputs name="inputs" data_style="staging_path_and_source_path"/>
</configfiles>
<inputs>
<param name="table" type="data" format="qza" label="table" help=""/>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue I don't know the inputs and the format
same pb for the outputs I just guessed


]]></command>
<inputs>
<param name="cpu" type="integer" value="0" label="CPU" help="TODO" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be put as default (did not find exactly how to do it in frogs fro now)

<param name="swarm_asv_seq" type="data" format="fasta" label="ASV swarm sequences" help="TODO" />
</inputs>
<outputs>
<data name="Swarm output" format="" from_work_dir="./output_dir/*" label="${tool.name} on ${on_string} output" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the format of the output, fasta ?

@Marie59
Copy link
Author

Marie59 commented Dec 13, 2024

Figaro Finished and working (planemo serve and test) with the entire dataset V4 of samba.
Left to do (need your help @lleroi)

  • Find the right edam ontologies and add them
  • need to think if we leave the input format this open or if we impose a format
  • Add help on all inputs ?
  • Add a help section in the bottom

& start conversion json csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants