[ re #3423 ] Make IClaimData to be a data, not record
#3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #3423 introduces a new data structure which added several top-level declarations with names
rig,vis,optsandtypewhich leads a lot of existing code to warnings of shadowing these top-level names with local variables. These names are pretty popular, especially for parameter names in certain contexts (even precisely this module has already several parameters named in this way).I believe that this was not the intended behaviour, to I suggest to declare
IClaimDatanot as arecord, like it's done with the typeRecordin the same module.Pinging @andrevidela as the original PR author.