-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add not LTE implies GT, and LTE implies maximum. #4428
Open
LeifW
wants to merge
2
commits into
idris-lang:master
Choose a base branch
from
LeifW:nat_gte
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,9 +149,9 @@ fromLteSucc (LTESucc x) = x | |
isLTE : (m, n : Nat) -> Dec (m `LTE` n) | ||
isLTE Z n = Yes LTEZero | ||
isLTE (S k) Z = No succNotLTEzero | ||
isLTE (S k) (S j) with (isLTE k j) | ||
isLTE (S k) (S j) | (Yes prf) = Yes (LTESucc prf) | ||
isLTE (S k) (S j) | (No contra) = No (contra . fromLteSucc) | ||
isLTE (S k) (S j) = case isLTE k j of | ||
Yes prf => Yes (LTESucc prf) | ||
No contra => No (contra . fromLteSucc) | ||
|
||
||| `LTE` is reflexive. | ||
lteRefl : LTE n n | ||
|
@@ -182,6 +182,12 @@ notLTImpliesGTE {b = Z} _ = LTEZero | |
notLTImpliesGTE {a = Z} {b = S k} notLt = absurd (notLt (LTESucc LTEZero)) | ||
notLTImpliesGTE {a = S k} {b = S j} notLt = LTESucc (notLTImpliesGTE (notLt . LTESucc)) | ||
|
||
||| If a number is not less than or equal to another, it is greater than it | ||
notLTEImpliesGT : Not (i `LTE` j) -> i `GT` j | ||
notLTEImpliesGT {i = Z} notLt = absurd $ notLt LTEZero | ||
notLTEImpliesGT {i = S k} {j = Z} _ = LTESucc LTEZero | ||
notLTEImpliesGT {i = S j} {j = S k} notLt = LTESucc (notLTEImpliesGT (notLt . LTESucc)) | ||
|
||
||| Boolean test than one Nat is less than or equal to another | ||
total lte : Nat -> Nat -> Bool | ||
lte Z right = True | ||
|
@@ -840,3 +846,9 @@ sucMinL (S l) = cong (sucMinL l) | |
total sucMinR : (l : Nat) -> minimum l (S l) = l | ||
sucMinR Z = Refl | ||
sucMinR (S l) = cong (sucMinR l) | ||
|
||
||| If one number is biggre than another, you know what the maximum is. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a small typo |
||
total lteImpliesMax : i `LTE` j -> maximum i j = j | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this should be added to |
||
lteImpliesMax {i = Z} _ = Refl | ||
lteImpliesMax {i = S k} {j = Z} _ impossible | ||
lteImpliesMax {i = S k} {j = S j} (LTESucc x) = cong {f = S} $ lteImpliesMax x |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for the change here? 😄