Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a generic selection component #8

Open
thejonan opened this issue Dec 8, 2016 · 1 comment
Open

Implement a generic selection component #8

thejonan opened this issue Dec 8, 2016 · 1 comment

Comments

@thejonan
Copy link
Contributor

thejonan commented Dec 8, 2016

Take the existing selection mechanism and wrap it as a generic skill-set. Few things are important here and need to be clarified:

  • It is important to have the (de)select mechanism in-browser, so the user doesn't need to wait for a server response to see the effect of her selection. However, certain storing of selection may be need on the server, still - no need to wait for it.
  • Currently the page's URL is changed on every selection so that sending the current URL also sends the selection. This has some additional problems, however. Probably it is a good idea to encapsulate the in-browser navigation possibilities in a separate skill-set (Implement a generic in-browser navigation skill-set #9).
@thejonan
Copy link
Contributor Author

thejonan commented Feb 4, 2017

From the perspective of the work made, the best possible approach is:

  • Have a urlBasketParameter configuration, so the skill knows where to take the selected IDs from.
  • Handle the afterTranslation callbacks and fill whatever possible of the listed IDs.
  • Provide the onOpen handler, so when combined with something like TabExpansion - Create TabExpansion widget #16 - can react on opening, and if still there are unmatched entries (only their IDs) - use the Spying skill from SolrJsX to launch a separate query for the remaining ones.

@thejonan thejonan removed the Research label Feb 4, 2017
@vedina vedina assigned thejonan and unassigned tmanolov May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants