Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for the lmsensors component #292

Merged

Conversation

Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Dec 5, 2024

Pull Request Description

This PR addresses adding tests for the lmsensors component as currently none exist.

This continues the updates for the overall GitHub CI for PAPI. As such, these tests will not take a command line argument; rather, we will search for events using PAPI_enum_cmp_event.

Truncated output for lmsensors_list_events.c:

Component index for lmsensors: 2
Event code Event name
1073741870 lmsensors:::coretemp-isa-0000.Package_id_0.temp1_input
1073741871 lmsensors:::coretemp-isa-0000.Package_id_0.temp1_max
1073741872 lmsensors:::coretemp-isa-0000.Package_id_0.temp1_crit
1073741873 lmsensors:::coretemp-isa-0000.Package_id_0.temp1_crit_alarm
....
Total number of events for lmsensor: 170
PASSED

Output for lmsensors_read.c:

Component index for lmsensors: 2
Successfully added lmsensors:::coretemp-isa-0000.Core_0.temp2_max to the EventSet.
Successfully added lmsensors:::coretemp-isa-0000.Core_1.temp3_max to the EventSet.
Successfully added lmsensors:::coretemp-isa-0000.Core_2.temp4_max to the EventSet.
Max temp output for events:
lmsensors:::coretemp-isa-0000.Core_0.temp2_max: 95000
lmsensors:::coretemp-isa-0000.Core_1.temp3_max: 95000
lmsensors:::coretemp-isa-0000.Core_2.temp4_max: 95000
PASSED

Tested with run_tests.sh when the lmsensors component is compiled in:

  • lmsensors tests show up in "The following test cases will be run" section when compiled in
  • lmsensors tests run and output in the "Running Component Tests" section

Tested with run_tests.sh when the lmsensors component is not compiled in:

  • lmsensors tests show up in "The following test cases will NOT be run" section

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

@Treece-Burgess Treece-Burgess force-pushed the 12.5.2024-lmsensors-tests branch from cab7d87 to a9e5c1b Compare December 13, 2024 21:37
@Treece-Burgess Treece-Burgess force-pushed the 12.5.2024-lmsensors-tests branch from ceb434b to 6d89be6 Compare December 13, 2024 22:04
@Treece-Burgess Treece-Burgess added component-lmsensors PRs and Issues related to the lmsensors component status-ready-to-merge PR is ready to be merged into master labels Dec 14, 2024
@Treece-Burgess Treece-Burgess merged commit 95ef27b into icl-utk-edu:master Dec 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-lmsensors PRs and Issues related to the lmsensors component status-ready-to-merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants