Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for moko-permissions 0.18.0 and update libraries #50

Merged
merged 14 commits into from
Sep 22, 2024

Conversation

burnoo
Copy link
Contributor

@burnoo burnoo commented Jul 6, 2024

Main goal of this PR is to make the library work with moko-permissions 0.18.0 and close #44. I've also updated most of dependencies in the project, and fix all issues that those updates caused.

Changes

Dependencies I haven't updated

  • Android Gradle plugin (conflict with moko KMP gradle plugin)
  • AppCompat - spotted some compilation issues with 1.7.0 version of the library

How I've tested those changes

Maven EAP

I wanted to use this those changes ASAP, so I've published the EAP of the library to my maven repository. It's a public maven, so anyone can use it while waiting for the official release.

Installation

Add maven In settings.gradle.kts (read more about versioning here)

dependencyResolutionManagement {
    repositories {
        maven(url = "https://pkgs.dev.azure.com/burnoo/maven/_packaging/public/maven/v1") {
            content {
                includeVersionByRegex(".*", ".*", ".*-beap[0-9]+")
            }
        }
    }
}

In your module:

implementation("dev.icerock.moko:geo:0.6.1-beap1")

@burnoo
Copy link
Contributor Author

burnoo commented Jul 6, 2024

It also fixes #48

@Alex009 Alex009 changed the base branch from master to develop July 7, 2024 17:08
@Alex009 Alex009 linked an issue Jul 7, 2024 that may be closed by this pull request
gradle.properties Show resolved Hide resolved
gradle.properties Show resolved Hide resolved
gradle/libs.versions.toml Show resolved Hide resolved
@Alex009 Alex009 added this to the 0.7.0 milestone Jul 7, 2024
@burnoo
Copy link
Contributor Author

burnoo commented Jul 8, 2024

What is the reason of using x64 while compiling on m1 GitHub actions runner? 🤔 (commit: b699ac6). It does not work on CI currently

It works with arm64 on this PR (I'm waiting with merging it till resolve this discussion: #50 (comment))

@Alex009 Alex009 mentioned this pull request Sep 22, 2024
@Alex009 Alex009 merged commit b699ac6 into icerockdev:develop Sep 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't use with ComponentActivity, bind issue Library is not compatible with moko permissions 0.18.0
2 participants