Fix image viewer not zooming #2726
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo030303
changed the title
|
The |
|
I tried not redrawing on those events and it all renders the same except the cursor icon doesn't change to the "grabbed" version when clicking, or it gets stuck as the grabbed version, so thought it was worthwhile leaving them in, see the videos for what I mean, I'm on Wayland with Gnome 43 No Redraw With Redraw |
|
Ah right, oops. |
|
I confirmed this patch fixed #2713. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2713
The image viewer update method wasn't requesting redraws, it now requests a redraw every time an event is captured.
I've tested this with the example app from the linked issue and it fixes the issue.