minor: comment

iboB · Jul 3, 2024 · 95bd8a3 · 95bd8a3
1 parent 4aab8ae
commit 95bd8a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/code/jalog/AsyncLogging.cpp b/code/jalog/AsyncLogging.cpp
@@ -31,7 +31,7 @@ class AsyncLoggingImpl final : public xec::ExecutorBase
     }
 
     // pack raw pointers along with the sinks to skip
-    // the control block hop of shared_ptr::->
+    // a potential control block hop of shared_ptr::->
     struct SinkData
     {
         SinkData(SinkPtr p) : ptr(std::move(p)), sink(ptr.get()) {}

diff --git a/code/jalog/Printf.cpp b/code/jalog/Printf.cpp
@@ -14,6 +14,8 @@ namespace jalog
 void VPrintfUnchecked(Scope& scope, Level lvl, const char* format, va_list args)
 {
     va_list acopy;
+    // we need to copy the va_list, because if our optimistic fit below doesn't fit, we would need to call
+    // vsnprintf again (and the first call would've consumed the original va_list)
     va_copy(acopy, args);
 
     // optimistically try to fit in a small buffer