Warn when patch isn't specified #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpaul10
force-pushed
the
feat/warn-on-pin-py-ver
branch
5 times, most recently
from
aefc391 to
653eb84
Compare
ianpaul10
force-pushed
the
feat/warn-on-pin-py-ver
branch
8 times, most recently
from
c574fdf to
6358b10
Compare
ianpaul10
force-pushed
the
feat/warn-on-pin-py-ver
branch
4 times, most recently
from
0a2f0c7 to
711ab6e
Compare
Warn when requires-python is set to an exact value (==) and doesn't include a patch (so it'll get set to 0)
ianpaul10
force-pushed
the
feat/warn-on-pin-py-ver
branch
from
711ab6e to
708cd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When patch version isn't specified and a matching version is referenced, it will default patch to 0 which could be unclear/confusing. This PR warns the user of that default.
Summary
The first part of this issue astral-sh#7426. Will tackle the second part mentioned (
~=) in a separate PR once I know this is the correct way to warn users.Test Plan
cargo run --features tracing -- pip install black==24.8 --verboseshould result in a warning message:I couldn't find a good example of test cases for
warnfunction calls and didn't know the best way to add it, but more than happy to do so. If someone could point me in the right direction that would be much appreciated :)