Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on the Contributors List Action #25

Closed
wants to merge 9 commits into from

Conversation

u-siri-ous
Copy link
Contributor

I found a similar Action, but maybe more complete, as it adds the name or username of the contributor as a URL and does not create an SVG.
This is the documentation about it, https://github.com/marketplace/actions/contribute-list

@iacopomasi
Copy link
Owner

Dear @u-siri-ous,

thank you for this update. I also saw this other github action before. I saw in your version of the website that we can link to the username but squared icons. Esthetically I prefer the graphics of the SVG with rounded avatars but here the link it is a plus. So I am undecided. Do you think this is better? Regardless, thank you again

@u-siri-ous
Copy link
Contributor Author

u-siri-ous commented May 15, 2023

Good afternoon professor,
I made the PR because I saw that the SVG Contributors List Github action wasn't working correctly some days ago, as some of the contributors were not showing in the SVG.
I agree that the rounded version does look better though, moreover, the second version creates clutter in the .md files.

The problem is that the new execution of the action somehow cancelled the correct SVG and substituted it with a new but wrong-generated SVG. This happened a few days ago, solved itself, and has happened again now.
This is visible from bot-commit 383cda3, which has c1d013c as the parent.

I think it can be solved by scheduling the action, or we can try and see if it sorts itself out at the next push, as it did before.

Also, I found that someone else is having the same problem and is currently waiting for a response from the creator of this action.
Here's the link to the Github Issue: wow-actions/contributors-list#6 .

Thank you for your time.

@iacopomasi
Copy link
Owner

Dear @u-siri-ous ,

Thank you for investigating this. I saw that now that I made some push,the SVG updated once again and I see new faces in the contrib list. For now we will stick to this but you can try in your fork to see if you can set 1) rounded avatars 2) remove the border in the tables with the new github action. This is not urgent and please priority studying for the exam to this.

What you could try is to write to wow-actions/contributors-list#6 and say also that we are getting the issue (this is less work).

thank you

@iacopomasi iacopomasi closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants