-
Notifications
You must be signed in to change notification settings - Fork 196
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OS-6767. Make ability to retag images for runkube with no-pull
## Description Now it is possible to use the --no-pull flag with any tag you need to update the cluster without pulling images ## Related issue number OS-6767 ## Checklist * [x] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
- Loading branch information
Showing
1 changed file
with
52 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d9c554
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tguisep please take a look on the updated runkube and tell us if you have any observations regarding it. Thanks!
3d9c554
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Func get_local_images & L166:
If
image
is not found twice, theimage
value will be None and the code will return an error on the objectimage.id
? (not tested).do we really want to continue the deployment if an image is missing ?
Else adding the parameter "LOCAL_TAG" should fix the issue, but I did had time to test the changes proposed on my setup.
@maxb-hystax