Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out string key and string value condition messages for label application rules #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner January 11, 2024 06:52
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3c6d8a3) 79.92% compared to head (af5ddfb) 79.92%.

Files Patch % Lines
...fig/service/LabelApplicationRuleValidatorImpl.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #198   +/-   ##
=========================================
  Coverage     79.92%   79.92%           
  Complexity      488      488           
=========================================
  Files            54       54           
  Lines          2416     2416           
  Branches        106      106           
=========================================
  Hits           1931     1931           
  Misses          425      425           
  Partials         60       60           
Flag Coverage Δ
integration 79.92% <92.85%> (ø)
unit 78.45% <92.85%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

120 tests  ±0   120 ✅ ±0   1m 1s ⏱️ +4s
 29 suites ±0     0 💤 ±0 
 29 files   ±0     0 ❌ ±0 

Results for commit af5ddfb. ± Comparison against base commit 3c6d8a3.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've verified compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants