Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage bot 🤖 #1548

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Conversation

LucasSte
Copy link
Contributor

@LucasSte LucasSte commented Sep 22, 2023

Coverage reports will be stored here.

According to Codecov's documentation,

Once merged to the default branch, subsequent pull requests will have checks and report comment.

This is an example of how comments look like: solana-labs/solana#33363 (comment)

@LucasSte LucasSte marked this pull request as ready for review September 22, 2023 16:43
@seanyoung
Copy link
Contributor

seanyoung commented Sep 23, 2023

This does not give a good representation of our coverage; the integration tests aren't run under llvm-cov. For example it looks like the language server is entirely without test coverage; there are no rust tests for the language server, since there is no rust client for a language server (it's tested in integration/vscode/).


coverage:
runs-on: ubuntu-latest
container: ghcr.io/hyperledger/solang-llvm:ci-5
Copy link
Contributor

@xermicus xermicus Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile we bumped this to ci-6, don't forget to update the image tag before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That has not been merged.

@LucasSte LucasSte marked this pull request as draft September 26, 2023 14:31
@codecov
Copy link

codecov bot commented Sep 26, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@LucasSte LucasSte force-pushed the code-bot branch 19 times, most recently from 4f42908 to 6d5183b Compare October 3, 2023 17:22
@LucasSte LucasSte force-pushed the code-bot branch 4 times, most recently from 191a3dc to 7e3f639 Compare October 5, 2023 17:57
@LucasSte LucasSte force-pushed the code-bot branch 2 times, most recently from aa9a69e to e07a90f Compare October 5, 2023 22:07
@LucasSte LucasSte marked this pull request as ready for review October 6, 2023 13:19
@LucasSte LucasSte requested a review from xermicus October 6, 2023 13:19
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, fantastic feature for the project

@@ -64,16 +78,29 @@ jobs:
run: cargo doc --workspace --bins
- name: Run cargo fmt
run: cargo fmt --all -- --check
- name: Build
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason if: always() has been removed?

The idea was that if clippy/rustfmt fails, then we can still try to build/test it (is this useful?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an oversight. I'll add that again.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this is great to have, thanks!

Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
@LucasSte LucasSte merged commit 817831a into hyperledger-solang:main Oct 12, 2023
19 checks passed
@LucasSte LucasSte deleted the code-bot branch October 12, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants