-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage bot 🤖 #1548
Add code coverage bot 🤖 #1548
Conversation
This does not give a good representation of our coverage; the integration tests aren't run under |
|
||
coverage: | ||
runs-on: ubuntu-latest | ||
container: ghcr.io/hyperledger/solang-llvm:ci-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meanwhile we bumped this to ci-6
, don't forget to update the image tag before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That has not been merged.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
4f42908
to
6d5183b
Compare
191a3dc
to
7e3f639
Compare
aa9a69e
to
e07a90f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, fantastic feature for the project
@@ -64,16 +78,29 @@ jobs: | |||
run: cargo doc --workspace --bins | |||
- name: Run cargo fmt | |||
run: cargo fmt --all -- --check | |||
- name: Build | |||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason if: always()
has been removed?
The idea was that if clippy/rustfmt fails, then we can still try to build/test it (is this useful?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was an oversight. I'll add that again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this is great to have, thanks!
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Signed-off-by: Lucas Steuernagel <[email protected]>
Coverage reports will be stored here.
According to Codecov's documentation,
This is an example of how comments look like: solana-labs/solana#33363 (comment)