Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared): add missing files for OS-specific command handling #2394

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat(shared): add missing files for OS-specific command handling #2394

merged 1 commit into from
Oct 19, 2023

Conversation

saurabhkumarkardam
Copy link
Contributor

Quick fix commit to be reviewed


feat(shared): add missing files for OS-specific command handling

Description:
- In the PR titled "feat(shared): enable OS-specific command handling in Helm charts," I forgot to include certain files.
- I thought that changing the name of the Helm chart would override the updated file only, not the entire chart, but I was wrong.
- This PR will address the missing file and fulfill the purpose of the original PR.

fixes #quick-fix

…elm charts

Description:
- In the PR titled "feat(shared): enable OS-specific command handling in Helm charts," I forgot to include certain files.
- I thought that changing the name of the Helm chart would override the updated file only, not the entire chart, but I was wrong.
- This PR will address the missing file and fulfill the purpose of the original PR.

fixes #quick-fix

Signed-off-by: saurabhkumarkardam <[email protected]>
Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suvajit-sarkar suvajit-sarkar merged commit 1cfb9ef into hyperledger-bevel:develop Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants