Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update agent setup docs to clarify mulitple RPC settings #305

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

edakturk14
Copy link
Collaborator

@edakturk14 edakturk14 commented Jan 24, 2025

This PR addresses issue #301

Key changes

  • Validator config doc: add multiple rpc url setup
  • Relayer config doc: add multiple rpc url setup
  • Config reference add: customGrpcUrls
  • Config reference: prettier formatting

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyp-v3-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:09am

@edakturk14 edakturk14 marked this pull request as ready for review January 27, 2025 05:12
@edakturk14 edakturk14 requested a review from tkporter January 27, 2025 05:12
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits and one bigger question about our customRpcUrl / customGrpcUrl configuration we do in the agents that I'd like Dan to chime in on

docs/operate/config-reference.mdx Outdated Show resolved Hide resolved
docs/operate/config-reference.mdx Outdated Show resolved Hide resolved
docs/operate/config-reference.mdx Show resolved Hide resolved
docs/operate/config-reference.mdx Show resolved Hide resolved
docs/operate/relayer/run-relayer.mdx Outdated Show resolved Hide resolved
docs/operate/relayer/run-relayer.mdx Outdated Show resolved Hide resolved
docs/operate/relayer/run-relayer.mdx Outdated Show resolved Hide resolved
docs/operate/validators/run-validators.mdx Outdated Show resolved Hide resolved
@tkporter
Copy link
Collaborator

tkporter commented Feb 3, 2025

Oh weird one of my comments didn't get added to the review, 1 sec

@edakturk14 edakturk14 merged commit fb6212b into hyperlane-xyz:main Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants