Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate logoURI path #497

Merged
merged 2 commits into from
Jan 16, 2025
Merged

chore: validate logoURI path #497

merged 2 commits into from
Jan 16, 2025

Conversation

Xaroz
Copy link
Contributor

@Xaroz Xaroz commented Jan 16, 2025

Description

fixes #496

Now validates that the path in logoURI for warp deployments actually exists, if it doesn't it will throw an error in the CI

Backward compatibility

Yes

Testing

Manual
image

Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: ab80b26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Xaroz Xaroz requested review from xeno097 and paulbalaji January 16, 2025 17:39
@Xaroz Xaroz requested a review from jmrossy January 16, 2025 18:04
@Xaroz Xaroz enabled auto-merge January 16, 2025 21:19
@Xaroz Xaroz disabled auto-merge January 16, 2025 21:19
@Xaroz Xaroz merged commit f86f9ae into main Jan 16, 2025
5 of 6 checks passed
@Xaroz Xaroz deleted the chore/validate-logoURI-path branch January 16, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that logoURI file actually exists
2 participants