Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): missing single chain resolver #5156

Merged
merged 28 commits into from
Jan 15, 2025

Conversation

ljankovic-txfusion
Copy link
Collaborator

@ljankovic-txfusion ljankovic-txfusion commented Jan 13, 2025

Description

  • Removed SingleChainResolver in favor of a single MultiChainResolver class
  • Fixed chain resolution logic to properly handle:
    • Single chain selection via argv.chain
    • Multiple chain selection via argv.chains
  • Added proper handling for empty chain arrays to prevent unexpected behavior

Drive-by changes

Related issues

None

Backward compatibility

Yes

Testing

Manual

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: d202f8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (585404d) to head (d202f8c).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5156   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@cmcewen cmcewen added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2025
@xeno097 xeno097 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into hyperlane-xyz:main with commit aad2c2d Jan 15, 2025
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants