-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cli): warp commands e2e tests #5121
base: main
Are you sure you want to change the base?
Conversation
…to xeno/warp-commands-e2e-tests
… different flag configs
… different flag combinations
…erent flags combinations
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5121 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
…to xeno/warp-commands-e2e-tests
@@ -0,0 +1,12 @@ | |||
form: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to add these config files in the monorepo root? Seems like the wrong place for them
return `${REGISTRY_PATH}/deployments/warp_routes/${tokenSymbol.toUpperCase()}/${chains.join( | ||
'-', | ||
)}-config.yaml`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the createWarpRouteConfigId
and BaseRegistry.getWarpRoutesPath
functions in the registry package can help you reduce duplication with Registry code here
Description
This PR tries to e2e test multiple use cases with
warp
commands to ensure that future changes that might break or change the commands' behavior are detected early.Drive-by changes
skipConfirmation
propagation in signer strategy codetest/warp
folderRelated issues
Backward compatibility
Testing