-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't crash relayer due to flaky RPCs #5115
Conversation
|
ca808d3
to
1c9af66
Compare
- instead of crashing relayer if any RPC calls fail we just log the error and metric
Co-authored-by: Danil Nemirovsky <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5115 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
…orepo into jeff/bad-rpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo nit
Description
build_mailboxes
andbuild_validator_announces
, we just log the error and metricDrive-by changes
Related issues
Fixes #4887
Backward compatibility
Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?
Yes
Testing
Added unittests to test ensure functions run correctly and log errors in metrics