Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't crash relayer due to flaky RPCs #5115

Merged
merged 8 commits into from
Jan 15, 2025
Merged

feat: don't crash relayer due to flaky RPCs #5115

merged 8 commits into from
Jan 15, 2025

Conversation

kamiyaa
Copy link
Collaborator

@kamiyaa kamiyaa commented Jan 7, 2025

Description

  • instead of crashing relayer if any RPC calls fail during build_mailboxes and build_validator_announces, we just log the error and metric
  • relayer will continue running without those chains

Drive-by changes

Related issues

Fixes #4887

Backward compatibility

Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?

Yes

Testing

Added unittests to test ensure functions run correctly and log errors in metrics

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: a495762

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kamiyaa kamiyaa force-pushed the jeff/bad-rpc branch 3 times, most recently from ca808d3 to 1c9af66 Compare January 7, 2025 14:04
 - instead of crashing relayer if any RPC calls fail
 we just log the error and metric
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (99c91d8) to head (a495762).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5115   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

rust/main/agents/relayer/src/relayer.rs Outdated Show resolved Hide resolved
rust/main/agents/relayer/src/relayer.rs Show resolved Hide resolved
rust/main/agents/relayer/src/relayer.rs Outdated Show resolved Hide resolved
rust/main/agents/relayer/src/relayer.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo nit

rust/main/agents/relayer/src/relayer.rs Outdated Show resolved Hide resolved
rust/main/agents/relayer/src/relayer.rs Outdated Show resolved Hide resolved
@tkporter tkporter enabled auto-merge January 15, 2025 14:01
@tkporter tkporter added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit c47511b Jan 15, 2025
42 checks passed
@tkporter tkporter deleted the jeff/bad-rpc branch January 15, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayer can still crash upon startup due to bad RPCs
3 participants