fix: status icon not showing on mobile #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Xaroz
commented
Dec 16, 2024
Comment on lines
102
to
104
| <LinkCell id={msgId} base64={base64} tdClasses="w-8"> | ||
| {statusIcon && ( | ||
| <span className="-translate-y-1/2 transform"> |
There was a problem hiding this comment.
Since we are not using absolute positioning anymore, it would cause borders to be missing, that is why I moved this condition like this
Xaroz
changed the title
jmrossy
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue that caused the icons to not show for mobile screens
absoluteposition on the icon span, that anchors to the main tablerelative(Kinda weird that it worked before). All the icons would absolute position to the center of the tableabsoluteposition on the icon, added a small width to theLinkCellso that it can display the icon