-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve Prometheus Metrics #1338
base: main
Are you sure you want to change the base?
Conversation
I've made some changes to the metrics, the docs are also updated. I've tested this by creating a Grafana dashboard and see how it would look: You can try to connect your Prometheus to Grafana though, I made a simple repo here: |
Theres some metrics without documentation, can we please add them: just an example among others nodejs_heap_space_size_available_bytes
nodejs_version_info
nodejs_gc_duration_seconds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments on documentations, but LGTM otherwise.
For this, this is basically default metrics by PromClient. I will add documentations for this |
…onika into story/prometheus-metrics
…onika into story/prometheus-metrics
Monika Pull Request (PR)
What feature/issue does this PR add
This PR clears up #1335 and #1336
How did you implement / how did you fix it
I made some new and improve existing exported metrics for Prometheus. The details are below:
monika_alerts_triggered
id
,name
,url
,method
,alertQuery
monika_alerts_triggered_total
monika_probes_running
id
monika_probes_running_total
monika_probes_status
id
,name
,url
,method
monika_probes_total
monika_request_response_size_bytes
id
,name
,url
,method
,statusCode
,result
monika_request_response_time_seconds
id
,name
,url
,method
,statusCode
,result
monika_request_status_code_info
id
,name
,url
,method
How to test
npm run start -- --prometheus 9090
localhost:9090/metrics
in browser