Support setting auth for RedisSentinel. (#4646)

hyperf · Mar 30, 2022 · c983a64 · c983a64
1 parent dea5124
commit c983a64
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/publish/redis.php b/publish/redis.php
@@ -29,6 +29,7 @@
             'nodes' => explode(';', env('REDIS_SENTINEL_NODE', '')),
             'persistent' => '',
             'read_timeout' => 0,
+            'auth' => null,
         ],
         'pool' => [
             'min_connections' => 1,

diff --git a/src/RedisConnection.php b/src/RedisConnection.php
@@ -208,6 +208,7 @@ protected function createRedisSentinel()
             $retryInterval = $this->config['retry_interval'] ?? 0;
             $readTimeout = $this->config['sentinel']['read_timeout'] ?? 0;
             $masterName = $this->config['sentinel']['master_name'] ?? '';
+            $auth = $this->config['sentinel']['auth'] ?? null;
             shuffle($nodes);
 
             $host = null;
@@ -221,7 +222,8 @@ protected function createRedisSentinel()
                         $timeout,
                         $persistent,
                         $retryInterval,
-                        $readTimeout
+                        $readTimeout,
+                        $auth
                     );
                     $masterInfo = $sentinel->getMasterAddrByName($masterName);
                     if (is_array($masterInfo) && count($masterInfo) >= 2) {

diff --git a/tests/RedisTest.php b/tests/RedisTest.php
@@ -182,6 +182,18 @@ public function testShuffleNodes()
         $this->assertSame(3, count($nodes));
     }
 
+    public function testRedisSentinelParams()
+    {
+        $rel = new \ReflectionClass(\RedisSentinel::class);
+        $method = $rel->getMethod('__construct');
+        $count = count($method->getParameters());
+        if ($count === 6) {
+            $this->markTestIncomplete('RedisSentinel don\'t support auth.');
+        }
+
+        $this->assertSame(7, $count);
+    }
+
     private function getRedis()
     {
         $container = $this->getContainer();