Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove diagnostics from default features #379

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hydroflow/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ tokio-util = { version = "0.7.4", features = [ "net", "codec" ] }
variadics = { path = "../variadics" }
rustc-hash = "1.1.0"

# Diagnostics feature does not work on wasm32.
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
hydroflow_macro = { optional = true, path = "../hydroflow_macro", features = ["diagnostics"] }

[dev-dependencies]
chrono = { version = "0.4.20", features = [ "serde" ], default-features = false }
clap = { version = "4.0.29", features = [ "derive" ] }
Expand Down
4 changes: 4 additions & 0 deletions hydroflow_datalog/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ syn = { version = "1.0.0", features = [ "parsing", "extra-traits" ] }
proc-macro2 = "1.0.27"
proc-macro-crate = "1.1.0"
hydroflow_datalog_core = { path = "../hydroflow_datalog_core" }

# Diagnostics feature does not work on wasm32.
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
hydroflow_datalog_core = { path = "../hydroflow_datalog_core", features = ["diagnostics" ] }
4 changes: 2 additions & 2 deletions hydroflow_datalog_core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition = "2021"
path = "src/lib.rs"

[features]
default = [ "diagnostics" ]
default = []
diagnostics = [ "hydroflow_lang/diagnostics" ]

[dependencies]
Expand All @@ -17,7 +17,7 @@ syn = { version = "1.0.0", features = [ "parsing", "extra-traits" ] }
proc-macro2 = "1.0.27"
proc-macro-crate = "1.1.0"
rust-sitter = "0.2.1"
hydroflow_lang = { path = "../hydroflow_lang", default-features = false }
hydroflow_lang = { path = "../hydroflow_lang" }

[build-dependencies]
rust-sitter-tool = "0.2.1"
Expand Down
2 changes: 1 addition & 1 deletion hydroflow_lang/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "0.1.0"
edition = "2021"

[features]
default = [ "diagnostics" ]
default = []
diagnostics = []

[dependencies]
Expand Down
4 changes: 4 additions & 0 deletions hydroflow_macro/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name = "hydroflow_macro"
version = "0.1.0"
edition = "2021"

[features]
default = []
diagnostics = [ "hydroflow_lang/diagnostics" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So because this is a proc macro, diagnostics should just always be on rather than behind a propagated feature.


[lib]
proc-macro = true

Expand Down