Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: replace glob with fast-glob #637

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

kricsleo
Copy link
Contributor

resolves #636

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bunchee ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 3:10am

@huozhi
Copy link
Owner

huozhi commented Jan 13, 2025

Thanks for the PR, can we change it to fast-glob as it's more battle tested. The install size difference is not that huge between tinyglobby and fast-glob. I can consider tinyglobby in the future

@kricsleo
Copy link
Contributor Author

Of course, fast-glob is also a great choice!

@huozhi huozhi changed the title chore: replace "glob" with "tinyglobby" enhance: replace glob with fast-glob Jan 14, 2025
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huozhi huozhi merged commit f1deba9 into huozhi:main Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "glob" with smaller size alternatives
2 participants