Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure bundle fallback wont go to types #633

Merged
merged 6 commits into from
Jan 11, 2025

Conversation

huozhi
Copy link
Owner

@huozhi huozhi commented Jan 11, 2025

When load a separate chunk with matched condition, always look for js bundle and avoid types

For instance, when import utils.js in index.js
In output: index.browser.js should match util.browser.js, if there's no matched condition then fallback to util.js

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bunchee ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 7:07pm

@huozhi huozhi merged commit 5c08e50 into main Jan 11, 2025
6 checks passed
@huozhi huozhi deleted the fix/condition-file-module-reference branch January 11, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant