Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default build target #287

Merged
merged 2 commits into from
Dec 2, 2023
Merged

fix: default build target #287

merged 2 commits into from
Dec 2, 2023

Conversation

thecuvii
Copy link
Contributor

@thecuvii thecuvii commented Dec 2, 2023

Align default target to es2016.

bunchee/README.md

Line 79 in 17121cc

- Target (`--target <target>`): Set ECMAScript target (default: `'es2016'`).

@huozhi huozhi self-requested a review December 2, 2023 08:25
huozhi
huozhi previously approved these changes Dec 2, 2023
View reviewed changes
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it was a mistake in the readme. It should be es2015 there.
Would you mind updating the readme instead? Thanks

@huozhi huozhi dismissed their stale review December 2, 2023 08:28

update readme instead

@thecuvii thecuvii requested a review from huozhi December 2, 2023 08:58
huozhi
huozhi approved these changes Dec 2, 2023
View reviewed changes
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huozhi huozhi merged commit de7b1d7 into huozhi:main Dec 2, 2023
4 checks passed
huozhi pushed a commit that referenced this pull request Dec 3, 2023
@thecuvii @huozhi
fix: default build target (#287)
bada615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecuvii @huozhi