Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto build bin field #282

Merged
merged 29 commits into from
Dec 3, 2023
Merged

feat: auto build bin field #282

merged 29 commits into from
Dec 3, 2023

Conversation

devjiwonchoi
Copy link
Contributor

@devjiwonchoi devjiwonchoi commented Nov 11, 2023 •
edited by huozhi
Loading

This PR adds an extra step on build-config to check if pkg.bin exists, and if so, treat it as the entry as well.
Added some hasBin checks to cases that throw an error when no exports exist.

By leveraging the exportsMap concept, we create a new one for pkg.bin like exports field, then create the corresponding build configs based on the binary export maps

Resolves #272

@devjiwonchoi
Add support for bin entry
1a9d0f0
@devjiwonchoi
Merge branch 'main' of github.com:devjiwonchoi/bunchee into bin
db35afd
@devjiwonchoi
TODO: output
71508af
@devjiwonchoi
Merge branch 'main' of github.com:devjiwonchoi/bunchee into bin
03e9471
@devjiwonchoi
add handling output config
a188064
@devjiwonchoi
fix: bin path is already dist path
0dbbde0
@devjiwonchoi
Update integration.test.ts
7e4670d
@devjiwonchoi
test: add multi-path test
ab6edaf
@devjiwonchoi
fix: add bin as not string case
1233b35
@devjiwonchoi
Merge branch 'bin' of github.com:devjiwonchoi/bunchee into bin
6b37808
@devjiwonchoi
fix: remove hello world console
2248913
@devjiwonchoi
refac: build-config
ab2972a
@devjiwonchoi
refac: exports
2b735bf
@devjiwonchoi
refac: exports
6886437
@devjiwonchoi
refac: move bin related codes from exports to build config
de72835
@devjiwonchoi
chore: remove unnecessary pkg from getExportTypeDist
290b03e
@devjiwonchoi
refac: dts and else outputs as one
6486090
@devjiwonchoi
lint fix
80cf0ae
@devjiwonchoi
fix: resolve type any
fe0e2b2
@devjiwonchoi
refac: skip loop if no filename
e17f328
@devjiwonchoi
test: add multi out dir
dc8816b
@devjiwonchoi
add tests
1503cef
devjiwonchoi
devjiwonchoi commented Nov 18, 2023
View reviewed changes
src/build-config.ts Outdated Show resolved Hide resolved
@devjiwonchoi devjiwonchoi marked this pull request as ready for review November 18, 2023 18:45
@devjiwonchoi
chore: modify comments
4e28e3f 
- removed unnecessarily created function
huozhi
huozhi reviewed Nov 22, 2023
View reviewed changes
src/bundle.ts Outdated Show resolved Hide resolved
devjiwonchoi and others added 2 commits November 22, 2023 12:04
@devjiwonchoi devjiwonchoi requested a review from huozhi November 22, 2023 03:21
huozhi
huozhi reviewed Nov 26, 2023
View reviewed changes
src/build-config.ts Outdated Show resolved Hide resolved
src/build-config.ts Outdated Show resolved Hide resolved
src/build-config.ts Outdated Show resolved Hide resolved
src/build-config.ts Outdated Show resolved Hide resolved
@devjiwonchoi devjiwonchoi marked this pull request as draft November 29, 2023 04:39
@huozhi huozhi marked this pull request as ready for review December 3, 2023 13:39
@huozhi huozhi changed the title feat: bin feat: auto build bin field Dec 3, 2023
huozhi
huozhi approved these changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this feature! I did some refactor to reduce implementation complexity that we don't need to change much about the architecture

@huozhi huozhi merged commit 35fa09c into huozhi:main Dec 3, 2023
4 checks passed
@huozhi huozhi mentioned this pull request Dec 3, 2023
Closed
@devjiwonchoi devjiwonchoi deleted the bin branch December 4, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support build "bin" field
2 participants
@devjiwonchoi @huozhi