feat: add support for qrevo curv #253
Merged
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
requested changes
Dec 3, 2024
|
Looks pretty good to me. I unfortunately have a problem with our release pipeline I still need to fix, but I will merge this once I get that fixed |
Christopher-Masselli
changed the title
humbertogontijo
previously approved these changes
Dec 18, 2024
Lash-L
requested changes
Dec 18, 2024
There was a problem hiding this comment.
I missed that lint is failing. Can you run lint on your branch locally? @Christopher-Masselli
You don't need to worry about commit lint, as we can fix that when we are merging
|
@Christopher-Masselli wanted to give a small poke -- are you able to fix the lint errors? |
Lash-L
requested changes
Jan 8, 2025
Lash-L
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
@humbertogontijo This should be good to merge now - just squash and rename so that commitlint is happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some inconsistencies with how Smart Plan was defined in the mappings some were as
customwith a comment and others weresmart_modeI just made it all smart_mode for the curv